about summary refs log tree commit diff
path: root/app/controllers/concerns
diff options
context:
space:
mode:
authorThibG <thib@sitedethib.com>2021-01-12 09:27:38 +0100
committerGitHub <noreply@github.com>2021-01-12 09:27:38 +0100
commit54d4e5252be8cd9fa780df46e06541da8263d368 (patch)
tree36ea8ee8f190ed388b7eb5f789ff1d305230b0fd /app/controllers/concerns
parent7bed25f3eabecc84268a4b6c254cc3e0738926b6 (diff)
Use Rails' index_by where it makes sense (#15542)
* Use Rails' index_by where it makes sense

* Fix tests

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Diffstat (limited to 'app/controllers/concerns')
-rw-r--r--app/controllers/concerns/cache_concern.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/controllers/concerns/cache_concern.rb b/app/controllers/concerns/cache_concern.rb
index 8d82eda5c..3fb4b962a 100644
--- a/app/controllers/concerns/cache_concern.rb
+++ b/app/controllers/concerns/cache_concern.rb
@@ -38,7 +38,7 @@ module CacheConcern
     klass.reload_stale_associations!(cached_keys_with_value.values) if klass.respond_to?(:reload_stale_associations!)
 
     unless uncached_ids.empty?
-      uncached = klass.where(id: uncached_ids).with_includes.each_with_object({}) { |item, h| h[item.id] = item }
+      uncached = klass.where(id: uncached_ids).with_includes.index_by(&:id)
 
       uncached.each_value do |item|
         Rails.cache.write(item, item)