about summary refs log tree commit diff
path: root/app/controllers/emojis_controller.rb
diff options
context:
space:
mode:
authorAkihiko Odaki <nekomanma@pixiv.co.jp>2020-08-28 16:27:33 +0900
committerGitHub <noreply@github.com>2020-08-28 09:27:33 +0200
commit552e886b648faa2a2229d86c7fd9abc8bb5ff99c (patch)
tree0df097a83922fd4f5f570e388c9e6acdc0da08f0 /app/controllers/emojis_controller.rb
parenta10f53aa6928d9ece5fa09c67eafaa21a0404b8d (diff)
Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673)
The old implementation had two queries:
1. The query constructed in Api::V1::FavouritesController#results
2. The query constructed in #cached_favourites, which is merged with 1.

Both of them are issued againt PostgreSQL. The combination of the two
queries caused the following problems:
- The small window between the two queries involves race conditions.
- Minor performance inefficiency.

Moreover, the construction of query 2, which involves merging with query
1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
returns an array when min_id parameter is specified. The behavior prevents
from merging the query, and in the real world, ActiveRecord simply ignores
the merge (!), which results in querying the entire scan of statuses and
favourites table.

This change fixes these issues by simply letting query 1 get all the works
done.
Diffstat (limited to 'app/controllers/emojis_controller.rb')
0 files changed, 0 insertions, 0 deletions