diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2022-01-23 18:10:10 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-23 18:10:10 +0100 |
| commit | 0a120d86d28e3f2e20455f56c1656f5d5f2f4af6 (patch) | |
| tree | 36b2184e4a61f655240880c1f50cd004cf6ec27f /app/controllers | |
| parent | a63495230a3a28e022504f36356cd75b17b635ba (diff) | |
Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.
Diffstat (limited to 'app/controllers')
0 files changed, 0 insertions, 0 deletions