diff options
| author | Kaspar V <casaper@users.noreply.github.com> | 2023-01-11 21:57:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-11 21:57:24 +0100 |
| commit | ae62e5fa533831c936b7bbeb12f5b7605125ce54 (patch) | |
| tree | 86317b957133dde2cc21c8018f55e2a7437f3d94 /app/lib/vacuum/statuses_vacuum.rb | |
| parent | a65f86ae5596d9c51a76cb05a3ebf5cd965df6ef (diff) | |
Fix/remove calling private method with send in model (#22951)
* fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.
Diffstat (limited to 'app/lib/vacuum/statuses_vacuum.rb')
| -rw-r--r-- | app/lib/vacuum/statuses_vacuum.rb | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/app/lib/vacuum/statuses_vacuum.rb b/app/lib/vacuum/statuses_vacuum.rb index d1c4e7197..28c087b1c 100644 --- a/app/lib/vacuum/statuses_vacuum.rb +++ b/app/lib/vacuum/statuses_vacuum.rb @@ -19,10 +19,7 @@ class Vacuum::StatusesVacuum # as the search index, must be handled first. statuses.direct_visibility .includes(mentions: :account) - .find_each do |status| - # TODO: replace temporary solution - call of private model method - status.send(:unlink_from_conversations) - end + .find_each(&:unlink_from_conversations!) remove_from_search_index(statuses.ids) if Chewy.enabled? # Foreign keys take care of most associated records for us. |