diff options
author | Claire <claire.github-309c@sitedethib.com> | 2021-03-19 13:14:57 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-19 13:14:57 +0100 |
commit | 741d0952b174740e70a09fe6db6862624dfe1e44 (patch) | |
tree | f7869ec70cf7ba04678bfc00f1032ae34228f5fa /app/models/account_stat.rb | |
parent | c31c95ffe4fbf80981a0ee03484d72ee6d75d2ee (diff) |
Improve account counters handling (#15913)
* Improve account counters handling * Use ActiveRecord::Base::sanitize_sql to pass values instead of interpolating them Keep using string interpolation for `key` as it is safe and using “ActiveRecord::Base::sanitize_sql_hash_for_assignment” would require stitching bits of SQL in a way that is not more easily checked for safety. * Add migration hook to catch PostgreSQL versions earlier than 9.5
Diffstat (limited to 'app/models/account_stat.rb')
-rw-r--r-- | app/models/account_stat.rb | 42 |
1 files changed, 0 insertions, 42 deletions
diff --git a/app/models/account_stat.rb b/app/models/account_stat.rb index e70b54d79..a826a9af3 100644 --- a/app/models/account_stat.rb +++ b/app/models/account_stat.rb @@ -18,46 +18,4 @@ class AccountStat < ApplicationRecord belongs_to :account, inverse_of: :account_stat update_index('accounts#account', :account) - - def increment_count!(key) - update(attributes_for_increment(key)) - rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotUnique - begin - reload_with_id - rescue ActiveRecord::RecordNotFound - return - end - - retry - end - - def decrement_count!(key) - update(attributes_for_decrement(key)) - rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotUnique - begin - reload_with_id - rescue ActiveRecord::RecordNotFound - return - end - - retry - end - - private - - def attributes_for_increment(key) - attrs = { key => public_send(key) + 1 } - attrs[:last_status_at] = Time.now.utc if key == :statuses_count - attrs - end - - def attributes_for_decrement(key) - attrs = { key => [public_send(key) - 1, 0].max } - attrs - end - - def reload_with_id - self.id = self.class.find_by!(account: account).id if new_record? - reload - end end |