about summary refs log tree commit diff
path: root/app/models/admin.rb
diff options
context:
space:
mode:
authorAkihiko Odaki <nekomanma@pixiv.co.jp>2020-08-25 20:39:35 +0900
committerGitHub <noreply@github.com>2020-08-25 13:39:35 +0200
commit41eeb9ebaa65abe3fcbab60847b69d2469726d8a (patch)
treef4ea8b1eee79722b5f0eb12f0b4067a58288c99f /app/models/admin.rb
parent9cadd40cf4e52a299ba828e84b6a4fddaf976afb (diff)
Use Status.group instead of Status.distinct in HashQueryService (#14662)
DISTINCT clause removes duplicated records according to all the selected
attributes. In reality, it can remove duplicated records only looking at
statuses.id, but the clause confuses the query planner and yields
insufficient performance.
The behavior is also problematic if the scope produced by HashQueryService
is used to query columns without id (using pluck method, for example). The
scope is expected to contain unique statuses, but the uniquness will be
evaluated with some arbitrary columns other than id.

GROUP BY clause resolves those problem by explicitly specifying the
column to take into account for the record distinction.

A workaround for the problem of DISTINCT clause in
Api::V1::Timelines::TagController is no longer necessary and removed.
Diffstat (limited to 'app/models/admin.rb')
0 files changed, 0 insertions, 0 deletions