diff options
| author | luigi <007.lva@gmail.com> | 2021-01-22 04:09:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-22 10:09:08 +0100 |
| commit | eb51e43fb4386120f77f2ff99581f15018a81bd4 (patch) | |
| tree | ac52a3d084a3eafc1a1943be8ab2393465abc1ec /app/models/concerns/omniauthable.rb | |
| parent | 7d0031a515a9ccd552fab9ad55b6edb7e0e5ba32 (diff) | |
Optimize some regex matching (#15528)
* Use Regex#match? * Replace =~ too * Avoid to call match? from Nil * Keep value of Regexp.last_match
Diffstat (limited to 'app/models/concerns/omniauthable.rb')
| -rw-r--r-- | app/models/concerns/omniauthable.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/concerns/omniauthable.rb b/app/models/concerns/omniauthable.rb index 4ea219537..79d671d10 100644 --- a/app/models/concerns/omniauthable.rb +++ b/app/models/concerns/omniauthable.rb @@ -57,7 +57,7 @@ module Omniauthable user = User.new(user_params_from_auth(email, auth)) - user.account.avatar_remote_url = auth.info.image if auth.info.image =~ /\A#{URI::DEFAULT_PARSER.make_regexp(%w(http https))}\z/ + user.account.avatar_remote_url = auth.info.image if /\A#{URI::DEFAULT_PARSER.make_regexp(%w(http https))}\z/.match?(auth.info.image) user.skip_confirmation! user.save! user |