diff options
author | Nick Schonning <nschonni@gmail.com> | 2023-02-18 17:09:40 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-19 07:09:40 +0900 |
commit | 2177daeae92b77be6797ba8f2ab6ebe1e641e078 (patch) | |
tree | 2cf004cd1611bd53f21cdb8021e98aa499448627 /app/models/concerns | |
parent | 167709f6b0731c163619c58afcb0ca11bb393e54 (diff) |
Autofix Rubocop Style/RedundantBegin (#23703)
Diffstat (limited to 'app/models/concerns')
-rw-r--r-- | app/models/concerns/account_merging.rb | 16 | ||||
-rw-r--r-- | app/models/concerns/pam_authenticable.rb | 12 |
2 files changed, 11 insertions, 17 deletions
diff --git a/app/models/concerns/account_merging.rb b/app/models/concerns/account_merging.rb index 8161761fb..41071633d 100644 --- a/app/models/concerns/account_merging.rb +++ b/app/models/concerns/account_merging.rb @@ -21,11 +21,9 @@ module AccountMerging owned_classes.each do |klass| klass.where(account_id: other_account.id).find_each do |record| - begin - record.update_attribute(:account_id, id) - rescue ActiveRecord::RecordNotUnique - next - end + record.update_attribute(:account_id, id) + rescue ActiveRecord::RecordNotUnique + next end end @@ -36,11 +34,9 @@ module AccountMerging target_classes.each do |klass| klass.where(target_account_id: other_account.id).find_each do |record| - begin - record.update_attribute(:target_account_id, id) - rescue ActiveRecord::RecordNotUnique - next - end + record.update_attribute(:target_account_id, id) + rescue ActiveRecord::RecordNotUnique + next end end diff --git a/app/models/concerns/pam_authenticable.rb b/app/models/concerns/pam_authenticable.rb index 6169d4dfa..f97f986a4 100644 --- a/app/models/concerns/pam_authenticable.rb +++ b/app/models/concerns/pam_authenticable.rb @@ -42,13 +42,11 @@ module PamAuthenticable def self.pam_get_user(attributes = {}) return nil unless attributes[:email] - resource = begin - if Devise.check_at_sign && !attributes[:email].index('@') - joins(:account).find_by(accounts: { username: attributes[:email] }) - else - find_by(email: attributes[:email]) - end - end + resource = if Devise.check_at_sign && !attributes[:email].index('@') + joins(:account).find_by(accounts: { username: attributes[:email] }) + else + find_by(email: attributes[:email]) + end if resource.nil? resource = new(email: attributes[:email], agreement: true) |