about summary refs log tree commit diff
path: root/app/models/form
diff options
context:
space:
mode:
authorThibG <thib@sitedethib.com>2019-06-30 00:12:38 +0200
committerEugen Rochko <eugen@zeonfederated.com>2019-06-30 00:12:38 +0200
commitf895bf198470c1d4a0299b454433fdf1c35ee2b0 (patch)
tree0f4bdfc8acc9edae5c8a6f753161d48b950ce32b /app/models/form
parentccc7fe3e1d04c7cabad916e4e57c7739743d5c91 (diff)
Optimize makeGetStatus (#11211)
* Optimize makeGetStatus

Because `ImmutableList.filter` always returns a new object and `createSelector`
memoizes based on object identity, the selector returned by `makeGetStatus`
would *always* execute.

To avoid that, we wrap `getFilters` into a new memoizer that memoizes based on
deep equality, thus returning the same object as long as the filters haven't
changed, allowing the memoization of `makeGetStatus` to work.

Furthermore, we memoize the compiled regexs instead of recomputing them each
time the selector is called.

* Fix memoized result being cleared too often

* Make notifications use memoized getFiltersRegex
Diffstat (limited to 'app/models/form')
0 files changed, 0 insertions, 0 deletions