about summary refs log tree commit diff
path: root/app/models/trends/base.rb
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2022-04-08 17:10:53 +0200
committerGitHub <noreply@github.com>2022-04-08 17:10:53 +0200
commitfd9a9b07c2cd19ef08d15e138fd3fc59fc5318b6 (patch)
tree2de019901aef5a8839223ea4b04c0fe0dc6a9557 /app/models/trends/base.rb
parent6b72641641a25ae664413d0d587080ffe70af6c2 (diff)
Fix trends returning less results per page when filtered in REST API (#17996)
- Change filtering and pagination to occur in SQL instead of Redis
- Change rank/score displayed on trends in admin UI to be locale-specific
Diffstat (limited to 'app/models/trends/base.rb')
-rw-r--r--app/models/trends/base.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/app/models/trends/base.rb b/app/models/trends/base.rb
index 7ed13228d..38a49246b 100644
--- a/app/models/trends/base.rb
+++ b/app/models/trends/base.rb
@@ -37,12 +37,12 @@ class Trends::Base
     Trends::Query.new(key_prefix, klass)
   end
 
-  def score(id)
-    redis.zscore("#{key_prefix}:all", id) || 0
+  def score(id, locale: nil)
+    redis.zscore([key_prefix, 'all', locale].compact.join(':'), id) || 0
   end
 
-  def rank(id)
-    redis.zrevrank("#{key_prefix}:allowed", id)
+  def rank(id, locale: nil)
+    redis.zrevrank([key_prefix, 'allowed', locale].compact.join(':'), id)
   end
 
   def currently_trending_ids(allowed, limit)