diff options
| author | ThibG <thib@sitedethib.com> | 2020-12-20 18:25:00 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-20 18:25:00 +0100 |
| commit | 7bf3c6e57b52cd9390f2140a1cc17292c281aacf (patch) | |
| tree | adde2393c2ba14cc18368670a058802c57b6dc45 /app/services/delete_account_service.rb | |
| parent | 9734c9b6fe2d2e4a980d8ad94c5de0300b23c809 (diff) | |
Fix AccountDeletionWorker crashing and clogging sidekiq queues (#15380)
* Fix account deletion workers being queued multiple times for a single account * Fix poll votes being unnecessarily instantiated on poll deletion * Fix favourites being unnecessarily instantiated on status deletion * Remove inaccurate comments * Delete polls instead of destroying them Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Diffstat (limited to 'app/services/delete_account_service.rb')
| -rw-r--r-- | app/services/delete_account_service.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/services/delete_account_service.rb b/app/services/delete_account_service.rb index 9cb80c95a..fe9b30b17 100644 --- a/app/services/delete_account_service.rb +++ b/app/services/delete_account_service.rb @@ -122,7 +122,9 @@ class DeleteAccountService < BaseService @account.polls.reorder(nil).find_each do |poll| next if @options[:reserve_username] && reported_status_ids.include?(poll.status_id) - poll.destroy + # We can safely delete the poll rather than destroy it, as any non-reported + # status should have been deleted already + poll.delete end associations_for_destruction.each do |association_name| |