diff options
| author | ThibG <thib@sitedethib.com> | 2019-11-21 16:04:52 +0100 |
|---|---|---|
| committer | Eugen Rochko <eugen@zeonfederated.com> | 2019-11-21 16:04:52 +0100 |
| commit | c656cc2191479551806d288bdfb6a30aa35bcb23 (patch) | |
| tree | 3423a53f2bd7015dbab123f6fa478807b188f5ff /app/services/fetch_link_card_service.rb | |
| parent | e86234b1e90975de6e507a86549f0eb4600c723b (diff) | |
Fix FetchLinkCardServices crashing on a tags without a target (#12159)
* Add test for links without targets * Fix FetchLinkCardServices crashing on a tags without a target
Diffstat (limited to 'app/services/fetch_link_card_service.rb')
| -rw-r--r-- | app/services/fetch_link_card_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb index 29880e8d8..5d4a7c303 100644 --- a/app/services/fetch_link_card_service.rb +++ b/app/services/fetch_link_card_service.rb @@ -67,7 +67,7 @@ class FetchLinkCardService < BaseService else html = Nokogiri::HTML(@status.text) links = html.css('a') - urls = links.map { |a| Addressable::URI.parse(a['href']).normalize unless skip_link?(a) }.compact + urls = links.map { |a| Addressable::URI.parse(a['href']) unless skip_link?(a) }.compact.map(&:normalize).compact end urls.reject { |uri| bad_url?(uri) }.first |