diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2021-04-21 04:46:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-21 04:46:09 +0200 |
| commit | 0b36e3419d4c4ce175f9db266ef5b3a49a9b3974 (patch) | |
| tree | 2aa9992c320c0bb23c493e6d1ee84d9bc2589bb4 /app/services/remove_status_service.rb | |
| parent | 2c322addf378d17b3962b545572a43cc9d36e526 (diff) | |
Fix processing of remote Delete activities (#16084)
* Add tests * Ensure deleted statuses are marked as such * Save some redis memory by not storing URIs in delete_upon_arrival values * Avoid possible race condition when processing incoming Deletes * Avoid potential duplicate Delete forwards * Lower lock durations to reduce issues in case of hard crash of the Rails process * Check for `lock.aquired?` and improve comment * Refactor RedisLock usage in app/lib/activitypub * Fix using incorrect or non-existent sender for relaying Deletes
Diffstat (limited to 'app/services/remove_status_service.rb')
| -rw-r--r-- | app/services/remove_status_service.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/app/services/remove_status_service.rb b/app/services/remove_status_service.rb index 2c2a26641..6e4d6e72a 100644 --- a/app/services/remove_status_service.rb +++ b/app/services/remove_status_service.rb @@ -16,6 +16,8 @@ class RemoveStatusService < BaseService @account = status.account @options = options + @status.discard + RedisLock.acquire(lock_options) do |lock| if lock.acquired? remove_from_self if @account.local? |