diff options
author | Claire <claire.github-309c@sitedethib.com> | 2023-01-18 16:47:56 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-01-18 16:47:56 +0100 |
commit | 68dcbcb7bf2cceb181a9b82d604d2c2829c0c78b (patch) | |
tree | e5163da1952ed573e3dc4eb89d5c56b0a3848e5a /app/services | |
parent | 30e895299ceff095da3e4c8ee50b3d003225f021 (diff) |
Add more specific error messages to HTTP signature verification (#21617)
* Return specific error on failure to parse Date header * Add error message when preferredUsername is not set * Change error report to be JSON and include more details * Change error report to differentiate unknown account and failed refresh * Add tests
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/activitypub/fetch_remote_actor_service.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/app/services/activitypub/fetch_remote_actor_service.rb b/app/services/activitypub/fetch_remote_actor_service.rb index a25fa54c4..4f60ea5e8 100644 --- a/app/services/activitypub/fetch_remote_actor_service.rb +++ b/app/services/activitypub/fetch_remote_actor_service.rb @@ -28,6 +28,7 @@ class ActivityPub::FetchRemoteActorService < BaseService raise Error, "Unsupported JSON-LD context for document #{uri}" unless supported_context? raise Error, "Unexpected object type for actor #{uri} (expected any of: #{SUPPORTED_TYPES})" unless expected_type? raise Error, "Actor #{uri} has moved to #{@json['movedTo']}" if break_on_redirect && @json['movedTo'].present? + raise Error, "Actor #{uri} has no 'preferredUsername', which is a requirement for Mastodon compatibility" unless @json['preferredUsername'].present? @uri = @json['id'] @username = @json['preferredUsername'] |