about summary refs log tree commit diff
path: root/app/services
diff options
context:
space:
mode:
authorRenato "Lond" Cerqueira <renato@lond.com.br>2018-01-18 16:12:10 +0100
committerEugen Rochko <eugen@zeonfederated.com>2018-01-18 16:12:10 +0100
commite56404be414ff2fc7ff11171fdd2b31a0658aa11 (patch)
treeb1fcff9cdf6f054506ef76dd1142ed8b79e4362a /app/services
parent7badad7797b487b411a2ab34e0f7413741974bb4 (diff)
When must_be_following_dm is on, only notify if recipient dm'ed user (#6283)
* When must_be_following_dm is on, only notify if recipient dm'ed user
Currently, when must_be_following_dm is on, if a user sends a direct
message replying to any status from the recipient, the recipient gets a
notification. This should not be the case, as if the recipient posted
something publicly this can be used to spam their notifications.

* Refactor replied_to_status_is_direct_message?
Following suggestion in PR
Diffstat (limited to 'app/services')
-rw-r--r--app/services/notify_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/notify_service.rb b/app/services/notify_service.rb
index d5960c3ad..ba086449c 100644
--- a/app/services/notify_service.rb
+++ b/app/services/notify_service.rb
@@ -54,7 +54,7 @@ class NotifyService < BaseService
   end
 
   def response_to_recipient?
-    @notification.target_status.in_reply_to_account_id == @recipient.id
+    @notification.target_status.in_reply_to_account_id == @recipient.id && @notification.target_status.thread&.direct_visibility?
   end
 
   def optional_non_following_and_direct?