diff options
| author | James Smith <119005+jgsmith@users.noreply.github.com> | 2022-08-24 22:40:38 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-25 04:40:38 +0200 |
| commit | 1165943968f8c79cfaccf30c392b14b4930d68e6 (patch) | |
| tree | 6fc77b1fe069ce90256deff8bc65f619f935cf56 /app/workers/unmerge_worker.rb | |
| parent | e682975afd9d476eaf938dfe753debfc20d4e603 (diff) | |
Mark job pods not to use Istio's envoy sidecar (#18415)
* Mark job pods not to use Istio's envoy sidecar Istio injects sidecars into pods to implement mTLS between pods. Jobs usually don't know about this, so they don't signal the Envoy process to stop when the job finishes. Since at least one process is running in the pod, Kubernetes doesn't consider the job to be completed, so it lingers. By adding the `sidecar.istio.io/inject` annotation set to `"false"`, we let Istio know that it should not inject the sidecar. If Istio is not installed, then this has no impact. * Support arbitrary job annotations in the Helm chart Rather than focus on Istio, this allows arbitrary annotations for job pods. * Add in-line documentation for pod/job annotations
Diffstat (limited to 'app/workers/unmerge_worker.rb')
0 files changed, 0 insertions, 0 deletions