about summary refs log tree commit diff
path: root/app
diff options
context:
space:
mode:
authorMatt Jankowski <mjankowski@thoughtbot.com>2017-05-30 16:28:58 -0400
committerGitHub <noreply@github.com>2017-05-30 16:28:58 -0400
commit1dcfb902024a7d4049306d9bc48c499856e2e429 (patch)
tree138cb9b489139095333ad26a74d92b4b8ab22ea6 /app
parent22cf18e16f2ff07e5cd6e90b53d1b038e1956c99 (diff)
Clean up api/salmon controller (#3449)
Diffstat (limited to 'app')
-rw-r--r--app/controllers/api/salmon_controller.rb18
1 files changed, 12 insertions, 6 deletions
diff --git a/app/controllers/api/salmon_controller.rb b/app/controllers/api/salmon_controller.rb
index 7fc5e548d..f611b48a0 100644
--- a/app/controllers/api/salmon_controller.rb
+++ b/app/controllers/api/salmon_controller.rb
@@ -5,10 +5,8 @@ class Api::SalmonController < ApiController
   respond_to :txt
 
   def update
-    payload = request.body.read
-
-    if !payload.nil? && verify?(payload)
-      SalmonWorker.perform_async(@account.id, payload.force_encoding('UTF-8'))
+    if verify_payload?
+      process_salmon
       head 201
     else
       head 202
@@ -21,7 +19,15 @@ class Api::SalmonController < ApiController
     @account = Account.find(params[:id])
   end
 
-  def verify?(payload)
-    VerifySalmonService.new.call(payload)
+  def payload
+    @_payload ||= request.body.read
+  end
+
+  def verify_payload?
+    payload.present? && VerifySalmonService.new.call(payload)
+  end
+
+  def process_salmon
+    SalmonWorker.perform_async(@account.id, payload.force_encoding('UTF-8'))
   end
 end