diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2021-10-14 19:59:21 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-14 19:59:21 +0200 |
| commit | 216570ad988108c69b7105740ab382c544c2b034 (patch) | |
| tree | b5aa48c8abe76d709c26d006589debaa7de5a0e9 /app | |
| parent | 5159ba26e485daaeded2288c1b02bd1e516e1ca6 (diff) | |
Fix scheduled statuses decreasing statuses counts (#16791)
* Add tests * Fix scheduled statuses decreasing statuses counts Fixes #16774
Diffstat (limited to 'app')
| -rw-r--r-- | app/models/status.rb | 2 | ||||
| -rw-r--r-- | app/services/post_status_service.rb | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/app/models/status.rb b/app/models/status.rb index 847921ac2..3acf759f9 100644 --- a/app/models/status.rb +++ b/app/models/status.rb @@ -426,7 +426,7 @@ class Status < ApplicationRecord end def decrement_counter_caches - return if direct_visibility? + return if direct_visibility? || new_record? account&.decrement_count!(:statuses_count) reblog&.decrement_count!(:reblogs_count) if reblog? diff --git a/app/services/post_status_service.rb b/app/services/post_status_service.rb index 0a383d6a3..85aaec4d6 100644 --- a/app/services/post_status_service.rb +++ b/app/services/post_status_service.rb @@ -74,6 +74,9 @@ class PostStatusService < BaseService status_for_validation = @account.statuses.build(status_attributes) if status_for_validation.valid? + # Marking the status as destroyed is necessary to prevent the status from being + # persisted when the associated media attachments get updated when creating the + # scheduled status. status_for_validation.destroy # The following transaction block is needed to wrap the UPDATEs to |