diff options
author | Sheogorath <sheogorath@shivering-isles.com> | 2022-11-10 19:10:38 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-11-10 19:10:38 +0100 |
commit | e868f419234b7e4338047d6e65fcffde7c787a1c (patch) | |
tree | dc15705a57db61d9d98c2dd231ede78898be256a /chart/templates/deployment-sidekiq.yaml | |
parent | 86d4b6f7c943dc5d0d3af95f6fbc705996511ada (diff) |
fix(chart): Fix gitops-incompatible random rolling (#20184)
This patch reworks the Pod rolling mechanism, which is supposed to update Pods with each migration run, but since the it generates a new random value on each helm execution, this will constantly roll all pods in a GitOps driven deployment, which reconciles the helm release. This is resolved by fixing the upgrade to the `.Release.Revision`, which should stay identical, unless config or helm release version have been changed. Further it introduces automatic rolls based on adjustments to the environment variables and secrets. The implementation uses a helper template, following the 1-2-N rule, and omitting code duplication. References: https://helm.sh/docs/chart_template_guide/builtin_objects/ https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
Diffstat (limited to 'chart/templates/deployment-sidekiq.yaml')
-rw-r--r-- | chart/templates/deployment-sidekiq.yaml | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chart/templates/deployment-sidekiq.yaml b/chart/templates/deployment-sidekiq.yaml index dd707a4d0..57051870f 100644 --- a/chart/templates/deployment-sidekiq.yaml +++ b/chart/templates/deployment-sidekiq.yaml @@ -16,11 +16,11 @@ spec: template: metadata: annotations: - {{- with .Values.podAnnotations }} + {{- with .Values.podAnnotations }} {{- toYaml . | nindent 8 }} - {{- end }} - # roll the pods to pick up any db migrations - rollme: {{ randAlphaNum 5 | quote }} + {{- end }} + # roll the pods to pick up any db migrations or other changes + {{- include "mastodon.rollingPodAnnotations" . | nindent 8 }} labels: {{- include "mastodon.selectorLabels" . | nindent 8 }} app.kubernetes.io/component: sidekiq |