about summary refs log tree commit diff
path: root/spec/controllers/api
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2016-09-21 01:34:14 +0200
committerEugen Rochko <eugen@zeonfederated.com>2016-09-21 01:50:31 +0200
commit4bec613897d8835bb78202c7a36691b654f14967 (patch)
tree9df22828377cbf32002086c64fb0c5cdae790e95 /spec/controllers/api
parent6d89edc4f772b10b61f9747482a155666077f20b (diff)
Fix #24 - Thread resolving for remote statuses
This is a big one, so let me enumerate:

Accounts as well as stream entry pages now contain Link headers that
reference the Atom feed and Webfinger URL for the former and Atom entry
for the latter. So you only need to HEAD those resources to get that
information, no need to download and parse HTML <link>s.

ProcessFeedService will now queue ThreadResolveWorker for each remote
status that it cannot find otherwise. Furthermore, entries are now
processed in reverse order (from bottom to top) in case a newer entry
references a chronologically previous one.

ThreadResolveWorker uses FetchRemoteStatusService to obtain a status
and attach the child status it was queued for to it.

FetchRemoteStatusService looks up the URL, first with a HEAD, tests
if it's an Atom feed, in which case it processes it directly. Next
for Link headers to the Atom feed, in which case that is fetched
and processed. Lastly if it's HTML, it is checked for <link>s to the Atom
feed, and if such is found, that is fetched and processed. The account for
the status is derived from author/name attribute in the XML and the hostname
in the URL (domain). FollowRemoteAccountService and ProcessFeedService
are used.

This means that potentially threads are resolved recursively until a dead-end
is encountered, however it is performed asynchronously over background jobs,
so it should be ok.
Diffstat (limited to 'spec/controllers/api')
-rw-r--r--spec/controllers/api/subscriptions_controller_spec.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/controllers/api/subscriptions_controller_spec.rb b/spec/controllers/api/subscriptions_controller_spec.rb
index ad0d0bc05..e0ae8d48e 100644
--- a/spec/controllers/api/subscriptions_controller_spec.rb
+++ b/spec/controllers/api/subscriptions_controller_spec.rb
@@ -24,6 +24,14 @@ RSpec.describe Api::SubscriptionsController, type: :controller do
 
     before do
       stub_request(:get, "https://quitter.no/avatar/7477-300-20160211190340.png").to_return(request_fixture('avatar.txt'))
+      stub_request(:head, "https://quitter.no/notice/1269244").to_return(status: 404)
+      stub_request(:head, "https://quitter.no/notice/1265331").to_return(status: 404)
+      stub_request(:head, "https://community.highlandarrow.com/notice/54411").to_return(status: 404)
+      stub_request(:head, "https://community.highlandarrow.com/notice/53857").to_return(status: 404)
+      stub_request(:head, "https://community.highlandarrow.com/notice/51852").to_return(status: 404)
+      stub_request(:head, "https://social.umeahackerspace.se/notice/424348").to_return(status: 404)
+      stub_request(:head, "https://community.highlandarrow.com/notice/50467").to_return(status: 404)
+      stub_request(:head, "https://quitter.no/notice/1243309").to_return(status: 404)
 
       request.env['HTTP_X_HUB_SIGNATURE'] = "sha1=#{OpenSSL::HMAC.hexdigest('sha1', 'abc', feed)}"
       request.env['RAW_POST_DATA'] = feed