diff options
author | Matt Jankowski <mjankowski@thoughtbot.com> | 2017-05-31 14:28:45 -0400 |
---|---|---|
committer | Eugen Rochko <eugen@zeonfederated.com> | 2017-05-31 20:28:45 +0200 |
commit | 2cc3111a7775066c34eb407cd3b4707acc659488 (patch) | |
tree | 64b3212472eb10df4b22709e4bf4b00e13ac8e47 /spec/models/account_spec.rb | |
parent | bf811e4d4a8626579fc5187f465cdf1e79a32e10 (diff) |
Expand spec coverage and refactor the `Account.find_` methods (#3485)
* Move specs for account finder methods to concern spec * Move account finder methods to concern * Improve spec wording * Use more explicit comparison to ensure correct return value * Add coverage for .find_local! and .find_remote! * Add some methods to the finder * Use arel on matching_username method * Avoid ternary in matching domain method * Simplify finder methods * Use an AccountFinder class to simplify lookup
Diffstat (limited to 'spec/models/account_spec.rb')
-rw-r--r-- | spec/models/account_spec.rb | 48 |
1 files changed, 0 insertions, 48 deletions
diff --git a/spec/models/account_spec.rb b/spec/models/account_spec.rb index 08098854b..ebec463e1 100644 --- a/spec/models/account_spec.rb +++ b/spec/models/account_spec.rb @@ -301,54 +301,6 @@ RSpec.describe Account, type: :model do end end - describe '.find_local' do - before do - Fabricate(:account, username: 'Alice') - end - - it 'returns Alice for alice' do - expect(Account.find_local('alice')).to_not be_nil - end - - it 'returns Alice for Alice' do - expect(Account.find_local('Alice')).to_not be_nil - end - - it 'does not return anything for a_ice' do - expect(Account.find_local('a_ice')).to be_nil - end - - it 'does not return anything for al%' do - expect(Account.find_local('al%')).to be_nil - end - end - - describe '.find_remote' do - before do - Fabricate(:account, username: 'Alice', domain: 'mastodon.social') - end - - it 'returns Alice for alice@mastodon.social' do - expect(Account.find_remote('alice', 'mastodon.social')).to_not be_nil - end - - it 'returns Alice for ALICE@MASTODON.SOCIAL' do - expect(Account.find_remote('ALICE', 'MASTODON.SOCIAL')).to_not be_nil - end - - it 'does not return anything for a_ice@mastodon.social' do - expect(Account.find_remote('a_ice', 'mastodon.social')).to be_nil - end - - it 'does not return anything for alice@m_stodon.social' do - expect(Account.find_remote('alice', 'm_stodon.social')).to be_nil - end - - it 'does not return anything for alice@m%' do - expect(Account.find_remote('alice', 'm%')).to be_nil - end - end - describe '.following_map' do it 'returns an hash' do expect(Account.following_map([], 1)).to be_a Hash |